Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added project management guidelines #2061

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Conversation

manjitapandey
Copy link
Contributor

@manjitapandey manjitapandey commented Jan 7, 2025

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Example: Fixes #921

Describe this PR

This PR contains the mapping guidelines for field mappers and training and project creation guidelines for project managers that may help them in using FMTM smoothly. It also includes the contraints FMTM has and encourage them to follow the certain workflow FMTM has to offer.

Screenshots

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

Signed-off-by: Manjita Pandey <[email protected]>
@github-actions github-actions bot added the docs Improvements or additions to documentation label Jan 7, 2025
@manjitapandey manjitapandey changed the title Add files via upload Added project management guidelines Jan 7, 2025
@manjitapandey manjitapandey marked this pull request as draft January 7, 2025 05:44
- Click on _I would like to include my own imagery layer for reference_
in the first step to add TMS URL. You can get the URL by uploading it in openaerialmap.

**ODK Central Credentials**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to use nested headings here so they appear on the sidebar (####), otherwose I'm sure the markdown linter will complain πŸ˜„

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spwoodcock , This helps me to fix the error.

- Ensure you have the map features ready for the area you plan
to survey before starting project creation.
- The files should be in GeoJSON format, use the WGS coordinate
system with EPSG 4326, and must not include a Z-coordinate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not strip a z coord if present? Of we don't, we probably should! This info can be omitted as it should be handled automatically for the user

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can do it from backend, I can create a ticket regarding so and remove it from here. But for now, this is the behavior.
cc: @Sujanadh

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have a function to strip z coordinates, but the current implementation doesn't work as expected. I will update the function to make sure it removes the z coordinate from geometry. Most of the cases when data extract do not work during splitting are due to missing tags. I think we don't need to check tags if it is custom extracts so will update that as well so there won't be any issue with custom extracts if they are valid. πŸ‘

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries @Sujanadh I made a new repo to handle this: https://github.com/hotosm/geojson-aoi-parser

Thought it might be handy to have all this logic in a module we can use in FMTM / Drone-TM / raw-data-api / other tools πŸ˜„

Healthcare only. We plan to add more types of features moving ahead.
- Project managers can also upload supporting map features. Note that these
secondary features can’t be surveyed but selected for respective primary features.
To understand the use cases, please follow the link here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a link somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Sorry, I was thinking I could dig in to some use cases of supporting map feature, document it somewhere and link it here but for now I can remove this from here.

@manjitapandey manjitapandey force-pushed the manjitapandey-patch-4 branch from 5b5628d to 3b15359 Compare January 7, 2025 11:34
@manjitapandey manjitapandey force-pushed the manjitapandey-patch-4 branch from b51c3c2 to c1779e4 Compare January 7, 2025 12:04
@manjitapandey manjitapandey marked this pull request as ready for review January 8, 2025 04:14
@manjitapandey manjitapandey merged commit 72653c7 into development Jan 8, 2025
2 checks passed
@manjitapandey manjitapandey deleted the manjitapandey-patch-4 branch January 8, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation throughout repo
3 participants