Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submission ids as a dataset property for the entities #2007

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

Sujanadh
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

  • new property submission_ids is added to dataset and entity properties in order to link each submissions with their respective entity.

Response

response of entity/status endpoint:

{
  "id": "8b3508c8-5ac5-4983-8e4a-d67c6ab51eb9",
  "task_id": 3,
  "osm_id": 954555442,
  "status": 2,
  "submission_id": "uuid:5db29b57-c104-4b74-a49d-a4ad042bc015,uuid:1cdf791b-285b-4bca-8c89-578d7cf71e48, uuid:f3c8a289-4bbc-4671-a780-c0111b374e7c",
  "updated_at": "2024-12-19T08:26:45.065Z"
}

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Sujanadh Sujanadh requested a review from spwoodcock December 19, 2024 09:25
@Sujanadh Sujanadh self-assigned this Dec 19, 2024
@github-actions github-actions bot added enhancement New feature or request backend Related to backend code labels Dec 19, 2024
@Sujanadh Sujanadh marked this pull request as draft December 19, 2024 10:05
@Sujanadh Sujanadh marked this pull request as ready for review December 20, 2024 08:36
@spwoodcock spwoodcock merged commit a79edb1 into development Dec 20, 2024
5 of 6 checks passed
@spwoodcock spwoodcock deleted the feat/sub-id-in-entities branch December 20, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants