Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/mapper frontend continuation #1823

Merged
merged 35 commits into from
Oct 18, 2024

Conversation

NSUWAL123
Copy link
Contributor

@NSUWAL123 NSUWAL123 commented Oct 16, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR contains the following works:

  1. Bottom sheet component add
  2. Update task styles for all task statuses
  3. UI enhancements
  4. Style fixes
  5. Tiptap Rich text editor add
  6. Geolocation with Device orientation functionality

Screenshots

image
image
image
image
image

@github-actions github-actions bot added the enhancement New feature or request label Oct 16, 2024
@github-actions github-actions bot added the frontend Related to frontend code label Oct 16, 2024
@NSUWAL123 NSUWAL123 marked this pull request as ready for review October 18, 2024 09:14
@NSUWAL123 NSUWAL123 requested a review from spwoodcock October 18, 2024 09:14
@@ -0,0 +1,48 @@
<script lang="ts">
import { clickOutside } from '../../../utilFunctions/clickOutside.ts';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible to use aliases here to avoid relative imports.

Svelte has a convention of using $. Currently we have $lib linking to src/lib and $components linking to src/components.

I'll merge this PR and we can update it later, perhaps we simply have a $src linking to src root dir to simplify things πŸ˜„

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

@spwoodcock
Copy link
Member

Nice work! Looking forward to setting this up πŸš€

@spwoodcock spwoodcock merged commit 6ad23e9 into development Oct 18, 2024
5 of 6 checks passed
@spwoodcock spwoodcock deleted the feat/mapper-frontend-continuation branch October 18, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants