Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to send messages to OSM users (notified via email) #1747

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented Aug 8, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Related to #1199
Related to #1573

Describe this PR

  • I updated osm-login-python to return the raw OSM OAuth token too.
  • This allows us to call the OSM API as needed, as the currently logged in user.
  • Added a helper endpoint to send a test email to the currently logged in user.
  • Last remaining things before ready:

Screenshots

image

image

I also received an email notification for the message πŸŽ‰

Alternative Approaches Considered

  • Adding an SMTP service to the tech stack.
  • Although managing both user email addresses and sending emails (without being marked as spam etc) is a hassle we don't need! (unless absolutely necessary).
  • This approach makes our life a lot easier, as FMTM is OSM-centric (even for flows outside of OSM, we can project managers to just sign up to OSM, it's not a big deal).

Review Guide

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock added enhancement New feature or request backend Related to backend code labels Aug 8, 2024
@spwoodcock spwoodcock self-assigned this Aug 8, 2024
@github-actions github-actions bot added the docs Improvements or additions to documentation label Aug 8, 2024
@spwoodcock spwoodcock marked this pull request as draft August 8, 2024 15:10
@spwoodcock spwoodcock marked this pull request as ready for review August 9, 2024 11:59
@spwoodcock spwoodcock merged commit d512d23 into development Aug 14, 2024
5 checks passed
@spwoodcock spwoodcock deleted the feat/osm-emails branch August 14, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code docs Improvements or additions to documentation enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

1 participant