Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id from the conflated geojson #1735

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Sujanadh
Copy link
Collaborator

@Sujanadh Sujanadh commented Aug 6, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

There was an issue loading multiple conflict geometries having same id field in geojson, when using OpenLayers.

Describe this PR

This PR updates the conflation removing id from the geojson of conflated features.

Screenshots

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Sujanadh Sujanadh requested a review from spwoodcock August 6, 2024 04:41
@Sujanadh Sujanadh self-assigned this Aug 6, 2024
@github-actions github-actions bot added bug Something isn't working backend Related to backend code labels Aug 6, 2024
@Sujanadh
Copy link
Collaborator Author

Sujanadh commented Aug 6, 2024

There isn't any big change; merging this now so that @NSUWAL123 can work on it.

@Sujanadh Sujanadh merged commit ba60616 into development Aug 6, 2024
5 checks passed
@Sujanadh Sujanadh deleted the fix/remove-id-from-conflate branch August 6, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant