-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ProjectUserDict usage and standardise geojson parsing/usage throughout #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
882c765
to
2f18f18
Compare
for more information, see https://pre-commit.ci
Thats a huge refactor π |
for more information, see https://pre-commit.ci
looks all good I tried creating project, made submissions, filter, review status, update entity status all seems working pretty good π |
Sujanadh
approved these changes
Jul 17, 2024
β¦to refactor/geojson-handling
for more information, see https://pre-commit.ci
Sujanadh
approved these changes
Jul 17, 2024
I added back your code from your last commit to better handle invalid multipolygon geoms which was removed when merging conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Related to #1657
Describe this PR
user
andproject
respectively..geojson
.@Sujanadh the remaining task:
current_user: AuthUser = Depends(mapper)
withproject_user: ProjectUserDict = Depends(mapper)
in submission_routes and task_routes.Review Guide
Test the things!
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?