Test for GET task history for a project #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spwoodcock
reviewed
Jul 4, 2024
| }, | ||
| } | ||
| try: | ||
| tasks = await project_crud.create_tasks_from_geojson( |
There was a problem hiding this comment.
Very nice, using an existing function as mentioned on slack 👍
spwoodcock
approved these changes
Jul 8, 2024
spwoodcock
added a commit
that referenced
this pull request
Jul 8, 2024
* fix(hotfix): download of basemaps in ui, max zoom level 22 used for tms * ci: update all gh-workflows to latest v1.6.0 * build: upgrade rclone --> v1 pin to avoid CVE-2024-24790 * build: remove unnecessary tables and field from db schema (#1623) * build: remove unnecessary tables via migration & simplify schema * refactor: remove references to removed tables in sqlalchemy models * build: add IF EXISTS to DROP COLUMN in migration * build: remove default columns from previous migration * fix(backend): minor fixes to HTTPException on endpoints * fix(backend): addded created date on the project response, set expiry of access token to 1 hour (#1633) * docs: add placeholder for axiom repo activity * fix(createProjectSlice): set generateProject & drawToggle status to default * feat(commonUtils): isStatusSuccess function add * test: get the detailed task history for a project (#1626) * build(backend): add async-lru dep, remove cpuinfo dep * fix: replace lru_cache with async for getting odk creds * fix(splitTasks): dependency add to useEffect * fix(createProjectService): halt project creation if api failure --------- Co-authored-by: spwoodcock <[email protected]> Co-authored-by: Sam <[email protected]> Co-authored-by: Sujan Adhikari <[email protected]> Co-authored-by: Azhar Ismagulova <[email protected]>
spwoodcock
added a commit
that referenced
this pull request
Jul 8, 2024
* fix(hotfix): download of basemaps in ui, max zoom level 22 used for tms * ci: update all gh-workflows to latest v1.6.0 * build: upgrade rclone --> v1 pin to avoid CVE-2024-24790 * build: remove unnecessary tables and field from db schema (#1623) * build: remove unnecessary tables via migration & simplify schema * refactor: remove references to removed tables in sqlalchemy models * build: add IF EXISTS to DROP COLUMN in migration * build: remove default columns from previous migration * fix(backend): minor fixes to HTTPException on endpoints * fix(backend): addded created date on the project response, set expiry of access token to 1 hour (#1633) * docs: add placeholder for axiom repo activity * fix(createProjectSlice): set generateProject & drawToggle status to default * feat(commonUtils): isStatusSuccess function add * test: get the detailed task history for a project (#1626) * build(backend): add async-lru dep, remove cpuinfo dep * fix: replace lru_cache with async for getting odk creds * fix(splitTasks): dependency add to useEffect * fix(createProjectService): halt project creation if api failure --------- Co-authored-by: spwoodcock <[email protected]> Co-authored-by: Sam <[email protected]> Co-authored-by: Sujan Adhikari <[email protected]> Co-authored-by: Azhar Ismagulova <[email protected]>
spwoodcock
added a commit
that referenced
this pull request
Jul 8, 2024
* fix(frontend): prevent project generation if api failure * Prevent project generation if api failure pt2 (#1635) * fix(hotfix): download of basemaps in ui, max zoom level 22 used for tms * ci: update all gh-workflows to latest v1.6.0 * build: upgrade rclone --> v1 pin to avoid CVE-2024-24790 * build: remove unnecessary tables and field from db schema (#1623) * build: remove unnecessary tables via migration & simplify schema * refactor: remove references to removed tables in sqlalchemy models * build: add IF EXISTS to DROP COLUMN in migration * build: remove default columns from previous migration * fix(backend): minor fixes to HTTPException on endpoints * fix(backend): addded created date on the project response, set expiry of access token to 1 hour (#1633) * docs: add placeholder for axiom repo activity * fix(createProjectSlice): set generateProject & drawToggle status to default * feat(commonUtils): isStatusSuccess function add * test: get the detailed task history for a project (#1626) * build(backend): add async-lru dep, remove cpuinfo dep * fix: replace lru_cache with async for getting odk creds * fix(splitTasks): dependency add to useEffect * fix(createProjectService): halt project creation if api failure --------- Co-authored-by: spwoodcock <[email protected]> Co-authored-by: Sam <[email protected]> Co-authored-by: Sujan Adhikari <[email protected]> Co-authored-by: Azhar Ismagulova <[email protected]> * build: update to latest ms playwright image v1.45.1 --------- Co-authored-by: Nishit Suwal <[email protected]> Co-authored-by: Sujan Adhikari <[email protected]> Co-authored-by: Azhar Ismagulova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Related to Issue #1614
Describe this PR
Added a test to get detailed task history for a project from
GET tasks/{task_id}/historyendpoint.Created
taskandtask_historyfixtures for test data.Screenshots
Alternative Approaches Considered
Did you attempt any other approaches that are not documented in code?
Review Guide
Command to run all tests defined in the project using pytest:
docker compose run --rm api pytestChecklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?