Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Matomo tracking web component, with accept/disagree prompt #1546

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented Jun 2, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Related #942

Describe this PR

  • Built on React v19 PR Upgrade React v18 --> v19Β #1545, so required that to be merged first (actually only 2 lines of new code in this PR).
  • Updated the Matomo code to use a @hotosm/ui web component instead.
  • Also includes a user accept/disagree notice, which is required by law.

Screenshots

image

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock added enhancement New feature or request frontend Related to frontend code labels Jun 2, 2024
@spwoodcock spwoodcock requested review from varun2948 and NSUWAL123 June 2, 2024 18:48
@spwoodcock spwoodcock self-assigned this Jun 2, 2024
@github-actions github-actions bot added the devops Related to deployment or configuration label Jun 2, 2024
@spwoodcock spwoodcock force-pushed the feat/matomo-web-component branch from 6cfe343 to 30abf42 Compare June 6, 2024 10:29
@github-actions github-actions bot removed the devops Related to deployment or configuration label Jun 6, 2024
@spwoodcock spwoodcock force-pushed the feat/matomo-web-component branch from 30abf42 to 5f7106b Compare June 7, 2024 11:12
@spwoodcock spwoodcock merged commit 9820853 into development Jun 7, 2024
4 checks passed
@spwoodcock spwoodcock deleted the feat/matomo-web-component branch June 7, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to frontend code
Projects
Development

Successfully merging this pull request may close these issues.

2 participants