Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading entity by intent using uuid xformid #1538

Merged
merged 9 commits into from
Jun 2, 2024

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Related to #1356

Describe this PR

  • There was an issue where the frontend ODK Collect intent URL was using the old {title}_{category} XFormID format.
  • I updated to pass the XFormID to the frontend for a project, then include in the intent URL.
  • I also fixed the form updating via the UI, which also required the XFormID to passed (to know which form to update.
  • Finally the script to modify the xform before upload was using the old task ids, and not the task index. Updated too.

Review Guide

  • This can be tested either on the development server, or via tunnel: just start tunnel.
  • A new project should be made with the tunnel ODK Central URL and loading by intent can be tested.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock added frontend Related to frontend code backend Related to backend code ODK Any requests for optimizing ODK labels May 24, 2024
@spwoodcock spwoodcock requested a review from Sujanadh May 24, 2024 13:58
@spwoodcock spwoodcock self-assigned this May 24, 2024
@github-actions github-actions bot removed the ODK Any requests for optimizing ODK label May 24, 2024
@spwoodcock spwoodcock added the testing:ready Ready for testing label May 24, 2024
@spwoodcock spwoodcock force-pushed the fix/odk-entity-by-intent branch from db74663 to f87383e Compare May 24, 2024 14:11
@spwoodcock
Copy link
Member Author

spwoodcock commented May 24, 2024

This works as intended, but when I try to submit the form I get an error:

signal-2024-05-24-153600_002

The 1691... value is the form id (xFormId), provided in the intent URL: odkcollect://form/xFormId?...
It seems to be causing an error somewhere?

@spwoodcock
Copy link
Member Author

spwoodcock commented May 29, 2024

Well crap, I forgot to include this in release 2024.3.0 @manjitapandey πŸ˜…

We will have to do a 2024.3.1 release.

@spwoodcock spwoodcock merged commit 7522348 into development Jun 2, 2024
7 checks passed
@spwoodcock spwoodcock deleted the fix/odk-entity-by-intent branch June 2, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code frontend Related to frontend code
Projects
Development

Successfully merging this pull request may close these issues.

2 participants