PHP7 consistent ordering for splitHttpAcceptHeader #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| require_once (__DIR__ . '/../../../lib/request/sfWebRequest.class.php'); | ||
|
|
||
| class sfWebRequestTest extends TestCase |
mdeheij
force-pushed
the
splitHttpAcceptHeader
branch
2 times, most recently
from
2b1c7ce to
cad5a33
Compare
In PHP7 sorting order is changed, splitHttpAcceptHeader was relying on unspecified behaviour of arsort(). Sorting order is now made explicit.
mdeheij
force-pushed
the
splitHttpAcceptHeader
branch
from
cad5a33 to
865bb94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP7 sorting order is changed, splitHttpAcceptHeader was
relying on unspecified behaviour of arsort(). Sorting order
is now made explicit.