Fixed compatibility with 3.3 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you can fix the Travis build 😬 |
.gitignore
Outdated
| @@ -2,3 +2,4 @@ | |||
| /test/Functional/Fixtures/logs | |||
There was a problem hiding this comment.
Shouldn't these logs be moved to var as well?
There was a problem hiding this comment.
no, but they can be removed now (/var is already excluding them)
| - php: 7.1 | ||
| env: COMPOSER_FLAGS="" SYMFONY_VERSION="dev-master" | ||
| allow_failures: | ||
| - php: 7.1 |
There was a problem hiding this comment.
We should verify running 7.1 with the latest stable Symfony works.
It's ok to have the dev-master fail, but stables should always work.
There was a problem hiding this comment.
7.1 is tested with --prefer-stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16
The argument sequence of the translator has been changed, causing 3.3 to not be able to construct the enum translator loader.