Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update to cli-table3 #1

Merged
merged 2 commits into from
Jun 26, 2018
Merged

fix(deps): update to cli-table3 #1

merged 2 commits into from
Jun 26, 2018

Conversation

schalkneethling
Copy link

This PR updates the cli-table2 dependency to cli-table3, which fixes one of the npm audit warnings :)

cli-table2 (like cli-table itself) is no longer maintained. In jamestalmage/cli-table2#43 a couple of people have offered to take over maintenance but the current maintainer did not respond so as a result the project was forked to cli-table/cli-table3.

@horacehylee
Copy link
Owner

Could you fix the error by changing the @types/lowdb@^1.0.2 in the yarn.lock file back to @types/lowdb@^1.0.0

@schalkneethling
Copy link
Author

@horacehylee I guess it upgraded to the latest because the version is not locked down to 1.0.0, that is an option to ensure this does not happen. So, are you happy if I lock it down? aka @types/[email protected]

@horacehylee
Copy link
Owner

@schalkneethling, Sure please lock it down for now, to let the test pass.
I will submit another pull request to update the use of lowdb with the latest type definition.
Thanks for the pull request.

yarn.lock Outdated

"@types/[email protected]":
version "4.14.80"
resolved "https://registry.yarnpkg.com/@types/lodash/-/lodash-4.14.80.tgz#a6b8b7900e6a7dcbc2e90d9b6dfbe3f6a7f69951"

"@types/lowdb@^1.0.0":
version "1.0.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change to make the tests pass

Copy link
Owner

@horacehylee horacehylee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please lock the @types/lowdb to v1.0.0 to let the test pass

@horacehylee
Copy link
Owner

@schalkneethling Thanks.

@horacehylee horacehylee merged commit 96dda52 into horacehylee:master Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants