Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TradeParty in Zugferd richtig nutzen #233

Closed
d135-1r43 opened this issue Jan 2, 2025 · 4 comments
Closed

TradeParty in Zugferd richtig nutzen #233

d135-1r43 opened this issue Jan 2, 2025 · 4 comments
Assignees
@Josh1ku

Comments

@d135-1r43
Copy link
Collaborator

d135-1r43 commented Jan 2, 2025 •
edited
Loading

org.mustangproject.TradeParty ist die richtige Entität, um Sender und Recipient zu ermitteln. Wir müssen diese Entitäten entsprechend in unsere JPA Objekte mappen.

Recipient hat Vorrang vor Payee. Wenn Recipient null, dann Fallback auf Payee. Ansonsten Payee und DeliveryAdress ignorieren. Wenn gar nix, dann ist unser Recipient null. Das kann und darf vorkommen, z. Bsp. bei einem einfachen REWE-Beleg ohne meine Adresse als Käufer.
@Josh1ku Josh1ku self-assigned this Jan 7, 2025
@3thr3n 3thr3n mentioned this issue Jan 11, 2025
Closed
@Josh1ku
Copy link
Contributor

Josh1ku commented Jan 13, 2025

Ist es nötig in fin/src/main/java/app/hopps/fin/kafka/model/AddressHelper.java die Straße und Hausnummer zu trennen? @d135-1r43

@d135-1r43
Copy link
Collaborator Author

Nö, muss nicht. Können wir gern zusammenlegen.

@3thr3n 3thr3n mentioned this issue Jan 24, 2025
Open
4 tasks
@d135-1r43
Copy link
Collaborator Author

@Josh1ku, bist du hier dran? #269 brauch das Feature.

3thr3n pushed a commit that referenced this issue Jan 27, 2025
🐛 (#233): Fixing tests
c808619
3thr3n pushed a commit that referenced this issue Jan 27, 2025
@3thr3n
🐛 (#233): Fixing tests
98e6e04
@3thr3n 3thr3n closed this as completed Jan 27, 2025
@3thr3n
Copy link
Contributor

3thr3n commented Jan 27, 2025

#232 ist nun entblocked. Bin dran.

3thr3n pushed a commit that referenced this issue Jan 27, 2025
@Josh1ku
✨ (#233). Conversion of TradeParty objects to Address
e015683
3thr3n pushed a commit that referenced this issue Jan 27, 2025
@Josh1ku
✨ (#233): Addition of TaxID, VatID and Description as attributes of T…
386c2b2 
…radeParty
d135-1r43 pushed a commit that referenced this issue Jan 28, 2025
@Josh1ku @d135-1r43
✨ (#233). Conversion of TradeParty objects to Address
7c6045a
d135-1r43 pushed a commit that referenced this issue Jan 28, 2025
@Josh1ku @d135-1r43
✨ (#233): Addition of TaxID, VatID and Description as attributes of T…
2999de8 
…radeParty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Josh1ku Josh1ku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/233-tradeparty-in-zugferd-richtig-nutzen hopps-app/hopps
3 participants
@d135-1r43 @3thr3n @Josh1ku