🚚 (#236): Rename example template

hopps-app · Feb 7, 2025 · 03a7924 · 03a7924
1 parent bb87f08
commit 03a7924
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 11 deletions.
diff --git a/backend/app.hopps.commons/src/main/java/app/hopps/commons/mail/MailTemplates.java b/backend/app.hopps.commons/src/main/java/app/hopps/commons/mail/MailTemplates.java
@@ -1,5 +1,5 @@
 package app.hopps.commons.mail;
 
 public enum MailTemplates {
-    TEMP
+    EXAMPLE
 }
diff --git a/backend/app.hopps.commons/src/test/java/app/hopps/commons/mail/MailTest.java b/backend/app.hopps.commons/src/test/java/app/hopps/commons/mail/MailTest.java
@@ -15,9 +15,9 @@ void testEquals() {
 
     @Test
     void testToString() {
-        Mail mail = new Mail(new String[] { "[email protected]", "[email protected]" }, MailTemplates.TEMP, Map.of());
+        Mail mail = new Mail(new String[] { "[email protected]", "[email protected]" }, MailTemplates.EXAMPLE, Map.of());
 
-        String expected = "Mail{mailReceivers=[[email protected], [email protected]], templateId=TEMP, variables={}}";
+        String expected = "Mail{mailReceivers=[[email protected], [email protected]], templateId=EXAMPLE, variables={}}";
 
         String actual = mail.toString();
 

diff --git a/backend/app.hopps.mailservice/src/main/java/app/hopps/mailservice/MailReceiver.java b/backend/app.hopps.mailservice/src/main/java/app/hopps/mailservice/MailReceiver.java
@@ -32,7 +32,7 @@ Uni<Void> handleRequest(Mail mail) {
     private Function<Map<String, String>, MailTemplate.MailTemplateInstance> getTemplateByType(
             MailTemplates mailTemplates) {
         return switch (mailTemplates) {
-            case TEMP -> Templates::temp;
+            case EXAMPLE -> Templates::example;
         };
     }
 }
diff --git a/backend/app.hopps.mailservice/src/main/java/app/hopps/mailservice/Templates.java b/backend/app.hopps.mailservice/src/main/java/app/hopps/mailservice/Templates.java
@@ -11,5 +11,5 @@ private Templates() {
         // static methods only
     }
 
-    public static native MailTemplate.MailTemplateInstance temp(Map<String, String> mapping);
+    public static native MailTemplate.MailTemplateInstance example(Map<String, String> mapping);
 }
diff --git a/...ce/src/main/resources/templates/temp.html → ...src/main/resources/templates/example.html b/...ce/src/main/resources/templates/temp.html → ...src/main/resources/templates/example.html
diff --git a/...ps.mailservice/src/test/java/app/hopps/mailservice/KafkaTestResourceLifecycleManager.java b/...ps.mailservice/src/test/java/app/hopps/mailservice/KafkaTestResourceLifecycleManager.java
@@ -10,10 +10,8 @@ public class KafkaTestResourceLifecycleManager implements QuarkusTestResourceLif
 
     @Override
     public Map<String, String> start() {
-        Map<String, String> env = new HashMap<>();
-        Map<String, String> props1 = InMemoryConnector.switchIncomingChannelsToInMemory("mail");
-        env.putAll(props1);
-        return env;
+        Map<String, String> mailKafkaProperties = InMemoryConnector.switchIncomingChannelsToInMemory("mail");
+        return new HashMap<>(mailKafkaProperties);
     }
 
     @Override

diff --git a/backend/app.hopps.mailservice/src/test/java/app/hopps/mailservice/MailReceiverTest.java b/backend/app.hopps.mailservice/src/test/java/app/hopps/mailservice/MailReceiverTest.java
@@ -40,7 +40,7 @@ void shouldSendMail() {
         InMemorySource<Mail> mailSender = connector.source("mail");
         mailSender.runOnVertxContext(true);
 
-        Mail mail = new Mail(new String[] { "[email protected]" }, MailTemplates.TEMP, Map.of("name", "Peter"));
+        Mail mail = new Mail(new String[] { "[email protected]" }, MailTemplates.EXAMPLE, Map.of("name", "Peter"));
 
         // when
         mailSender.send(mail);
@@ -58,7 +58,7 @@ void shouldSendMultipleMailsParallel() {
         InMemorySource<Mail> mailSender = connector.source("mail");
         mailSender.runOnVertxContext(true);
 
-        Mail mail = new Mail(new String[] { "[email protected]" }, MailTemplates.TEMP, Map.of("name", "Peter"));
+        Mail mail = new Mail(new String[] { "[email protected]" }, MailTemplates.EXAMPLE, Map.of("name", "Peter"));
 
         // when
         for (int i = 0; i < 500; i++) {