Fix wrong confirmation of overwriting #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry I was late to confirm your post because I didn't select "Be notified of all conversations". |
kaorahi
pushed a commit
to kaorahi/lizzie
that referenced
this pull request
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Congrats to your (first?) pull request featurecat#795 . :)
Would you merge my pull request into yours? It fixes another bug on filename extensions. We need to check overwriting AFTER adding ".sgf" if it is missing. Otherwise, when we input "foo", Lizzie will overwrite "foo.sgf" without warning.
See GitHub Docs to merge my pull request. I recommend [Rebase and merge] in that page in this case.