Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added no-referrer meta tag and subresource integrity #4

Merged
merged 9 commits into from
Nov 5, 2018

Conversation

SvenTo
Copy link
Contributor

@SvenTo SvenTo commented Oct 25, 2018

Hi,
I've added the no-referrer meta tag and subresource integrity for all third-party (CDN) resource to protect the confidentiality of NMap scans.

@honze-net
Copy link
Owner

Hi Sven,

Thank you for your contribution. At this point I do not entirely understand the problem. So I try to rephrase it, please correct me, if I am wrong.

At first I see the no-referrer meta tag. This is a good addition and it is out of question, I would like to merge that. But why the other changes. As I understand I added the hashes to pin the external code. In your commit the datatables css is missing. The hashes for the external resources have changed. Can you explain your intention a bit more, so I can understand every change. This would be a great help.

Thanks,

Andreas

@honze-net honze-net self-assigned this Oct 25, 2018
@honze-net honze-net added enhancement New feature or request question Further information is requested labels Oct 25, 2018
@honze-net
Copy link
Owner

Now it looks better, I will test the pull request in my scenarios I created. Unfortunately my build environment has to be reconfigured, because one of my file servers died. So this will take me some time, but I am confident, that the pull request will be merged around next week.

@SvenTo
Copy link
Contributor Author

SvenTo commented Nov 2, 2018

Hi Andreas,
sorry, I've added the patch but missed to answer the pull request: Yes, the changed it was just a mistake. Thank you for this nice report template! :-)

@honze-net honze-net changed the base branch from master to Dev November 5, 2018 20:13
@honze-net honze-net merged commit 5a8c84c into honze-net:Dev Nov 5, 2018
@honze-net
Copy link
Owner

I merged your pull request into the Dev branch to test it and verify all changes. After that I will merge it into master. Thank you again for your contribution!

@honze-net honze-net added enhancement New feature or request and removed enhancement New feature or request question Further information is requested labels Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants