feat(oauth-providers): availbility to pass state into oauth middlewares #917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which middleware is the feature for?
@hono/oauth-providers
What is the feature you are proposing?
Currently, I see that
@hono/oauth-providers
supports discord, facebook, github, google, linkedin, x OAuth. I have just test for github and google and it works probably.But I face a problem, I want to configure the URL that clients can be redirected after authorized successfully (redirect from Hono context, not from the providers, they are callbacks).
Then, I see that the
googleAuth.ts
has a options that can pass the state:Then I can pass the
clientRedirectUrl
to the state, and extract it later.But when dealing with Github (or other providers like the code I see), they don't have parameter
state
?The above block is the
githubAuth.ts
for exampleAre there any reasons that we cannot pass the state to the middlewares? From my side, I think it's inconsistent when we do like that. And of course, I love to have a parameter "state", it will help for my case.