Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql-server): the resolver always has context as the argument #705

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

metrue
Copy link
Contributor

@metrue metrue commented Aug 22, 2024

This PR is to improve the type of root resolver function.

Closes #655

Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: 9a78879

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/graphql-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@3w36zj6 3w36zj6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the issue I opened.

@yusukebe
Copy link
Member

Hey @metrue

Can you run yarn changeset to create a changeset and push it?

@metrue metrue requested a review from 3w36zj6 August 24, 2024 16:37
@metrue metrue force-pushed the metrue/non-nullable branch from f976b5a to 0f88b2b Compare August 24, 2024 16:48
@metrue
Copy link
Contributor Author

metrue commented Aug 24, 2024

@yusukebe done, please help review it.

Copy link
Contributor

@3w36zj6 3w36zj6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yusukebe yusukebe changed the title feat(types): the resolver always has context as the argument fix(types): the resolver always has context as the argument Aug 25, 2024
@yusukebe yusukebe changed the title fix(types): the resolver always has context as the argument fix(graphql-server): the resolver always has context as the argument Aug 25, 2024
@yusukebe
Copy link
Member

@metrue

I think this change is a patch fix. So, I've updated the changeset and pushed it myself. Let's go with it. Thanks!

@yusukebe yusukebe merged commit 9cac146 into honojs:main Aug 25, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve type definitions for arguments in RootResolver of graphql-server
3 participants