Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zod-openapi): return type of handler should be MaybePromise #522

Merged
merged 4 commits into from
May 15, 2024

Conversation

alexzhang1030
Copy link
Contributor

closes #521

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: aece886

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/zod-openapi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe
Copy link
Member

Hi @alexzhang1030

Thank you for the quick fix! Could you see the CI error?

@alexzhang1030
Copy link
Contributor Author

@yusukebe done! Looks like something is not lint well, I removed the duplicate things now.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@alexzhang1030

Thanks! Merging now.

@yusukebe yusukebe merged commit 2d5ef82 into honojs:main May 15, 2024
1 check passed
@alexzhang1030 alexzhang1030 deleted the fix/types branch May 15, 2024 07:52
@github-actions github-actions bot mentioned this pull request May 15, 2024
@akineko
Copy link
Contributor

akineko commented May 15, 2024

Thank you all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zod-openapi] Unable to use async handler
3 participants