feat(zod-openapi): Make it possible to do method chaining even for do… #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d4f9480 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Karibash
force-pushed
the
feature/zod-openapi-method-chain
branch
from
f082af5 to
9e910c4
Compare
Karibash
force-pushed
the
feature/zod-openapi-method-chain
branch
from
9e910c4 to
904fb48
Compare
yusukebe
reviewed
Nov 17, 2023
packages/zod-openapi/src/index.ts
Outdated
| doc = <P extends string>( | ||
| path: P, | ||
| config: OpenAPIObjectConfig | ||
| ): OpenAPIHono<E, S & ToSchema<'get', P, {}, OpenAPIObject>, BasePath> => { |
There was a problem hiding this comment.
The below is OK.
OpenAPIHono<E, S & ToSchema<'get', P, {}, {}>, BasePath>There was a problem hiding this comment.
Since this method does not use the jsonT method
Yes, you are right. It does not use jsonT()! Your fix is good.
packages/zod-openapi/src/index.ts
Outdated
| doc31 = <P extends string>( | ||
| path: P, | ||
| config: OpenAPIObjectConfig | ||
| ): OpenAPIHono<E, S & ToSchema<'get', P, {}, OpenAPIObject>, BasePath> => { |
Karibash
force-pushed
the
feature/zod-openapi-method-chain
branch
from
3915c72 to
d4f9480
Compare
|
Thanks! Looks good to me. I'll merge this now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…c methods
I implemented it so that doc methods can also do method chaining.
I am not so sure if I implemented it properly because the type is too complicated.