Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logger): max length of log can be specified #3903

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EdamAme-x
Copy link
Contributor

@EdamAme-x EdamAme-x commented Feb 7, 2025

This can mitigate the risk of attack.

Related: #3702 (comment)

logger({
  printFunc: logFunc,
  maxLength: 64,
})
// No breaking changes are made because past formats are also supported.
logger(logFunc)
--> GET /hhhhhhhhhhhhhhh... 200 0ms

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (4203973) to head (96f01fd).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3903    +/-   ##
========================================
  Coverage   91.27%   91.28%            
========================================
  Files         168      168            
  Lines       10750    10761    +11     
  Branches     3164     3048   -116     
========================================
+ Hits         9812     9823    +11     
  Misses        937      937            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdamAme-x
Copy link
Contributor Author

@ryuapp @yusukebe
Can you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant