refactor(helper/streaming): Avoid attaching AbortSignal on newer versions of Bun #3859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating a memory leak, I noticed that the streams helpers in hono unconditionally attach an AbortSignal to each request. As of Bun v1.1.27, we call
cancel
on ReadableStream so this should be unnecessary.I verified that on Bun v1.1.26, hardcoding the
isOldBunVersion
function to return false caused the abort-related tests to hang and that on Bun v1.2 hardcoding theisOldBunVersion
function to return false those tests pass.There is duplicate code but it felt less invasive to duplicate the code.
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code