Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helper/adapter): env should set c type correctly #3856

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Jan 26, 2025

Fixes #3854

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

Bundle size check

main (d75e9ec) #3856 (b900952) +/-
Bundle Size (B) 18,771B 18,771B 0B
Bundle Size (KB) 18.33K 18.33K 0K

Compiler Diagnostics

main (d75e9ec) #3856 (b900952) +/-
Files 257 257 0
Lines 115,048 115,048 0
Identifiers 112,929 112,929 0
Symbols 301,429 301,429 0
Types 213,638 213,638 0
Instantiations 3,090,073 3,090,073 0
Memory used 440,773K 446,798K 6,025K
I/O read 0.04s 0.02s -0.02s
I/O write 0s 0s 0s
Parse time 0.67s 0.82s 0.15s
Bind time 0.3s 0.32s 0.02s
Check time 6.1s 5.5s -0.6s
Emit time 0s 0s 0s
Total time 7.07s 6.64s -0.43s

Reported by octocov

@yusukebe
Copy link
Member Author

Hi @arolson101

I think this will resolve the problem. Can you review this?

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (ecf5a0b) to head (a682b1b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3856    +/-   ##
========================================
  Coverage   91.32%   91.32%            
========================================
  Files         161      161            
  Lines       10242    10242            
  Branches     2891     2997   +106     
========================================
  Hits         9353     9353            
  Misses        888      888            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arolson101
Copy link

looks good to me; thank you!

@yusukebe
Copy link
Member Author

@arolson101

Thanks! Merging.

@yusukebe yusukebe merged commit f5e9f3a into main Jan 26, 2025
16 checks passed
@yusukebe yusukebe deleted the fix/adapter-helper-env-types branch January 26, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typings problem with env in hono/adapter
2 participants