Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(factory): correct the type of factory.createMiddleware() #3849

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

yusukebe
Copy link
Member

Fixes #3847

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

Bundle size check

main (3fba7a5) #3849 (0bf2bf7) +/-
Bundle Size (B) 18,771B 18,771B 0B
Bundle Size (KB) 18.33K 18.33K 0K

Compiler Diagnostics

main (3fba7a5) #3849 (0bf2bf7) +/-
Files 257 257 0
Lines 115,045 115,045 0
Identifiers 112,920 112,920 0
Symbols 301,426 301,426 0
Types 213,590 213,590 0
Instantiations 3,089,848 3,089,848 0
Memory used 445,523K 444,527K -996K
I/O read 0.03s 0.02s -0.01s
I/O write 0s 0s 0s
Parse time 0.69s 0.8s 0.11s
Bind time 0.29s 0.36s 0.07s
Check time 5.44s 5.41s -0.03s
Emit time 0s 0s 0s
Total time 6.42s 6.57s 0.15s

Reported by octocov

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (3fba7a5) to head (dbfe247).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3849   +/-   ##
=======================================
  Coverage   91.31%   91.32%           
=======================================
  Files         161      161           
  Lines       10240    10242    +2     
  Branches     2926     2902   -24     
=======================================
+ Hits         9351     9353    +2     
  Misses        888      888           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe yusukebe merged commit 7a7918d into main Jan 23, 2025
16 checks passed
@yusukebe yusukebe deleted the fix/factory-types-create-middleware branch January 23, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

factory.createMiddleware() breaks the client's typing.
1 participant