-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): fix progress of log #3665
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3665 +/- ##
=======================================
Coverage 91.70% 91.70%
=======================================
Files 159 159
Lines 10145 10145
Branches 2868 2831 -37
=======================================
Hits 9303 9303
Misses 840 840
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Hi @EdamAme-x Indeed, we can fix it. How about this implementation? diff --git a/build/build.ts b/build/build.ts
index 34285bb7..7e31934e 100644
--- a/build/build.ts
+++ b/build/build.ts
@@ -102,7 +102,7 @@ const dtsEntries = glob.globSync('./dist/types/**/*.d.ts')
const writer = stdout.writer()
writer.write('\n')
let lastOutputLength = 0
-for (let i = 0; i < dtsEntries.length; i++) {
+for (let i = 1; i < dtsEntries.length + 1; i++) {
const entry = dtsEntries[i]
const message = `Removing private fields(${i}/${dtsEntries.length}): ${entry}` |
okay, I'll try |
I was try it, I think the code is a little redundant. for (let i = 1; i < dtsEntries.length + 1; i++) {
const entry = dtsEntries[i - 1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
You are right. My code was bad. Thanks! |
Before
Removing private fields(0/170): dist\types\types.d.ts
After
Removing private fields(1/170): dist\types\types.d.ts
Progress should start at 1