fix(helper/websocket): allow custom events to be passed to generics #3616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No suggestions |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3616 +/- ##
==========================================
+ Coverage 89.74% 89.77% +0.02%
==========================================
Files 158 158
Lines 10094 10090 -4
Branches 2827 2825 -2
==========================================
- Hits 9059 9058 -1
+ Misses 1035 1032 -3 ☔ View full report in Codecov by Sentry. |
|
Unrelated, but I also added the missing test WebSocketPair's mock is incomplete, so it is slightly hardcoded. |
|
Changing the type definition is a good idea! Thank you. |
TinsFox
pushed a commit
to TinsFox/hono
that referenced
this pull request
Nov 11, 2024
…onojs#3616) * fix(helper/websocket): allow custom events to be passed to generics * chore: disable any * add tests * patch * test patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3610
Also, make the
onOpenevent, which is not available incloudflare-workers, not included in the type.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code