Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helper/conninfo): add undefined for AddressType #3112

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Jul 8, 2024

This is optional, but it should allow an undefined.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.14%. Comparing base (58f421f) to head (2fd88dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3112   +/-   ##
=======================================
  Coverage   96.14%   96.14%           
=======================================
  Files         142      142           
  Lines       14457    14457           
  Branches     2513     2517    +4     
=======================================
  Hits        13899    13899           
  Misses        558      558           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe yusukebe merged commit fa5b742 into next Jul 8, 2024
14 checks passed
@yusukebe yusukebe deleted the fix/helper-conninfo-types branch July 8, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant