-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jsx/dom): skip calculate children if props are the same #3049
feat(jsx/dom): skip calculate children if props are the same #3049
Conversation
@yusukebe re-created! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3049 +/- ##
========================================
Coverage 96.02% 96.03%
========================================
Files 142 142
Lines 14271 14289 +18
Branches 2445 2592 +147
========================================
+ Hits 13704 13722 +18
Misses 567 567 ☔ View full report in Codecov by Sentry. |
Hi, @usualoma Thanks for fixing it. Screen.Recording.2024-06-27.at.17.39.20.mov |
@sor4chi Thank you. Sorry for the hassle. In my environment, it works as follows. CleanShot.2024-06-27.at.18.22.43.mp4I've built and archived the hono from this pull request branch into a tgz archive and created a version to install from there, so can I ask you to try this again with the node_modules removed? https://github.com/usualoma/explore-react-compiler-with-hono-jsx/tree/install-hono-via-tgz |
Sorry, I tried it in various ways, tgz, local link, etc, but it didn't work. Maybe it's my environment... |
Thanks, the test looks fine and it seems to be completely my environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Oops, the biggest point of React, the feature of not calculating the child element again if the properties are exactly the same, was not implemented. So it seems that https://github.com/orgs/honojs/discussions/3044 did not give the expected result.
If this pull request is merged, it would benefit from optimisation by React Compiler.
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code