Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsx/dom): implement "<Context> as a provider" for compatibility with React 19 #2962

Merged

Conversation

usualoma
Copy link
Member

#2959

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.63%. Comparing base (75663ff) to head (651be00).

Files Patch % Lines
src/jsx/context.ts 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2962      +/-   ##
==========================================
- Coverage   94.64%   94.63%   -0.01%     
==========================================
  Files         136      136              
  Lines       13324    13320       -4     
  Branches     2259     2271      +12     
==========================================
- Hits        12610    12606       -4     
  Misses        714      714              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usualoma usualoma changed the base branch from main to react-19-compat June 11, 2024 21:35
@usualoma
Copy link
Member Author

@yusukebe
This has been completed; please review it.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@usualoma

Thanks! I'll merge this into the react-19-compat now.

@yusukebe yusukebe merged commit 327da00 into honojs:react-19-compat Jun 13, 2024
14 checks passed
yusukebe pushed a commit that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants