fix(aws-lambda): handle multiple cookies in streaming responses #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix does address that cookies have to be handled specially in lambda responses. Fixes honojs#2921
|
It fails in the coverage check because of some GitHub rate-limit. 😿 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2926 +/- ##
==========================================
+ Coverage 94.11% 94.73% +0.62%
==========================================
Files 136 136
Lines 13382 13335 -47
Branches 2347 2261 -86
==========================================
+ Hits 12594 12633 +39
+ Misses 788 702 -86 ☔ View full report in Codecov by Sentry. |
watany-dev
reviewed
Jun 7, 2024
| // Check content type | ||
| const httpResponseMetadata = { | ||
| statusCode: res.status, | ||
| headers: Object.fromEntries(res.headers.entries()), | ||
| headers, | ||
| cookies, |
There was a problem hiding this comment.
|
@watany-dev Any chance to get this merged? |
|
Sorry for not responding to you! It seems to be good. But if you can, can you write a unit test? |
|
@yusukebe I would love to, unfortunately I cannot figure out how the Btw: The tests are not failing but stacktraces in the test output are printed. |
yusukebe
changed the title
|
@watany-dev Do you have any ideas for testing |
|
@yusukebe Found a way to test the cookies (and other headers) in the stream. Can you accept that solution? |
|
@yusukebe What else can I do to get this merged? |
|
Sorry for my late reply. This is great! I appreciate you added the test. Let's go with it. I'll merge it and release a minor version, including it later. Thanks. |
|
Hi @yusukebe, can you do a minor release with this patch? We are seeing this issue and waiting for a fix. |
|
I've released the |
NamesMT
added a commit
to NamesMT/hono-adapter-aws-lambda
that referenced
this pull request
Jun 17, 2024
nicolewhite
referenced
this pull request
in autoblocksai/cli
Jun 24, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [hono](https://hono.dev/) ([source](https://github.com/honojs/hono)) | [`4.4.4` -> `4.4.7`](https://renovatebot.com/diffs/npm/hono/4.4.4/4.4.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>honojs/hono (hono)</summary> ### [`v4.4.7`](https://github.com/honojs/hono/releases/tag/v4.4.7) [Compare Source](https://github.com/honojs/hono/compare/v4.4.6...v4.4.7) #### What's Changed - use correct return type for c.html depending on input by [@​asmadsen](https://github.com/asmadsen) in [https://github.com/honojs/hono/pull/2973](https://github.com/honojs/hono/pull/2973) - test: test uncovered return statement by [@​yasuaki640](https://github.com/yasuaki640) in [https://github.com/honojs/hono/pull/2985](https://github.com/honojs/hono/pull/2985) - test: Update request.test.ts to remove duplicate checks by [@​JoaquimLey](https://github.com/JoaquimLey) in [https://github.com/honojs/hono/pull/2984](https://github.com/honojs/hono/pull/2984) - fix(types): env variables override ContextVariableMap by [@​KaelWD](https://github.com/KaelWD) in [https://github.com/honojs/hono/pull/2987](https://github.com/honojs/hono/pull/2987) #### New Contributors - [@​asmadsen](https://github.com/asmadsen) made their first contribution in [https://github.com/honojs/hono/pull/2973](https://github.com/honojs/hono/pull/2973) - [@​JoaquimLey](https://github.com/JoaquimLey) made their first contribution in [https://github.com/honojs/hono/pull/2984](https://github.com/honojs/hono/pull/2984) - [@​KaelWD](https://github.com/KaelWD) made their first contribution in [https://github.com/honojs/hono/pull/2987](https://github.com/honojs/hono/pull/2987) **Full Changelog**: honojs/hono@v4.4.6...v4.4.7 ### [`v4.4.6`](https://github.com/honojs/hono/releases/tag/v4.4.6) [Compare Source](https://github.com/honojs/hono/compare/v4.4.5...v4.4.6) ##### What's Changed - fix(aws-lambda): handle multiple cookies in streaming responses by [@​KnisterPeter](https://github.com/KnisterPeter) in [https://github.com/honojs/hono/pull/2926](https://github.com/honojs/hono/pull/2926) **Full Changelog**: honojs/hono@v4.4.5...v4.4.6 ### [`v4.4.5`](https://github.com/honojs/hono/releases/tag/v4.4.5) [Compare Source](https://github.com/honojs/hono/compare/v4.4.4...v4.4.5) ##### What's Changed - fix(cors): allow custom vary header by [@​fzn0x](https://github.com/fzn0x) in [https://github.com/honojs/hono/pull/2934](https://github.com/honojs/hono/pull/2934) - fix(jsx): rename `Hono` to `JSX` and export `JSX` namespace by [@​yusukebe](https://github.com/yusukebe) in [https://github.com/honojs/hono/pull/2937](https://github.com/honojs/hono/pull/2937) - refactor(hono-base): make 2nd arg of `app.route()` required by [@​yusukebe](https://github.com/yusukebe) in [https://github.com/honojs/hono/pull/2945](https://github.com/honojs/hono/pull/2945) - refactor(hono-base): don't check 1st argument of `app.on()` by [@​yusukebe](https://github.com/yusukebe) in [https://github.com/honojs/hono/pull/2946](https://github.com/honojs/hono/pull/2946) - refactor(context): remove unnecessary initialization add add tests for Context by [@​yusukebe](https://github.com/yusukebe) in [https://github.com/honojs/hono/pull/2949](https://github.com/honojs/hono/pull/2949) - test(hono-base): add tests for covering 100% by [@​yusukebe](https://github.com/yusukebe) in [https://github.com/honojs/hono/pull/2952](https://github.com/honojs/hono/pull/2952) - fix(context): default JSONRespond and TextRespond StatusCode generic arg by [@​EdamAme-x](https://github.com/EdamAme-x) in [https://github.com/honojs/hono/pull/2954](https://github.com/honojs/hono/pull/2954) - refactor(request): shorten `parseBody` and remove unnecessary check by [@​yusukebe](https://github.com/yusukebe) in [https://github.com/honojs/hono/pull/2947](https://github.com/honojs/hono/pull/2947) - refactor(jsx): reduce code size and improve maintainability by [@​usualoma](https://github.com/usualoma) in [https://github.com/honojs/hono/pull/2956](https://github.com/honojs/hono/pull/2956) **Full Changelog**: honojs/hono@v4.4.4...v4.4.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone America/Chicago, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/autoblocksai/cli). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix does address that cookies have to be handled
specially in lambda responses.
Fixes #2921