Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: Make smoke tests more reliable #321

Merged
merged 8 commits into from
Dec 1, 2023
Merged

maint: Make smoke tests more reliable #321

merged 8 commits into from
Dec 1, 2023

Conversation

MikeGoldsmith
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith commented Nov 30, 2023 •
edited
Loading

Which problem is this PR solving?

Makes the smoke tests run more reliably.

Short description of the changes

  • Update rollout timeouts for network agent and echoserver to 60 seconds, they return as soon as they complete so it's okay to have a long timeout
  • Decrease the number of echoserver replicas from 5 to 1, we don't need 5 and it increases the rollout time
  • Update the smokey_copy_output makefile target to remove old version of the file if present and increase the wait time from 12 to 30 seconds

How to verify that this has the expected result

The smoke tests run more reliably both in CI and locally.

@MikeGoldsmith MikeGoldsmith added type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Nov 30, 2023
@MikeGoldsmith MikeGoldsmith self-assigned this Nov 30, 2023
@MikeGoldsmith MikeGoldsmith requested a review from a team November 30, 2023 10:28
@MikeGoldsmith MikeGoldsmith changed the title maint: Make smoke tests run more reliably maint: Make smoke tests more reliable Nov 30, 2023
@MikeGoldsmith MikeGoldsmith mentioned this pull request Dec 1, 2023
Merged
robbkidd
robbkidd approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@robbkidd robbkidd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets us going. 👍🏻

We can fiddle with shortening the long sleep later.

@MikeGoldsmith MikeGoldsmith merged commit b6d9f5c into main Dec 1, 2023
@MikeGoldsmith MikeGoldsmith deleted the mike/smoke-timeouts branch December 1, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbkidd robbkidd robbkidd approved these changes

Assignees

@MikeGoldsmith MikeGoldsmith

Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smoke tests do not run reliably
2 participants
@MikeGoldsmith @robbkidd