maint: Log when request/response timestamp is not set & set to time.Now #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
the
type: maintenance
JamieDanielson
approved these changes
Sep 14, 2023
| event.ResponseTimestamp = time.Now() | ||
| } | ||
| eventDuration := event.ResponseTimestamp.Sub(event.RequestTimestamp) | ||
|
|
There was a problem hiding this comment.
Should we add an extra check in here for other goofiness like request timestamp being greater than response timestamp? Something like if eventDuration < 0 { eventDuration = 0 }
There was a problem hiding this comment.
I don't think we need it - whenever we've seen a negative duration it's because the response timestamp is zero (ie 0001-01-01T00:00:00Z) which means the duration is calculated badly. I think because of the TCP requirement of request then response, as long as we have both sides, we can calculate the duration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The agent occasionally pairs a http request/response pair where the response timestamp is zero. This results in a negative huge value when trying to calculate the event duration.
This PR moves the event duration calculation from the http reader to event processing, detects if either the request or response timestamp is zero and sets to now &
Short description of the changes
How to verify that this has the expected result
While negative durations are infrequent (eg 3 in 24 hours), we have a kibble board to track which should show no further negative durations.