Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic smoke test #78

Closed
MikeGoldsmith opened this issue Aug 16, 2023 · 1 comment · Fixed by #310
Closed

Add basic smoke test #78

MikeGoldsmith opened this issue Aug 16, 2023 · 1 comment · Fixed by #310
Labels
type: maintenance The necessary chores to keep the dust off.
Milestone
Pre beta

Comments

@MikeGoldsmith
Copy link
Contributor

No description provided.

@MikeGoldsmith MikeGoldsmith added the type: enhancement New feature or request label Aug 16, 2023
@robbkidd robbkidd added type: maintenance The necessary chores to keep the dust off. and removed type: enhancement New feature or request labels Sep 20, 2023
@MikeGoldsmith
Copy link
Contributor Author

This will be a lot easier once #290 is done.

This was referenced Oct 31, 2023
Closed
Merged
MikeGoldsmith added a commit that referenced this issue Nov 30, 2023
@robbkidd @MikeGoldsmith @JamieDanielson
maint: adding proper smoke test(s) (#310)
9b5bfcd 
## Which problem is this PR solving?

- Closes #78 

## Description of the changes

Set up a smoke test, details included in the new make targets below:
- `smokey_cluster_create`: Create kind cluster
- `smokey_collector_install`: Install collector via helm with new
collector values, including a filter processor that only keeps
echoserver spans from pods with a response code of 405
- `smokey_agent_install`: Install agent via helm with new agent values,
including usage of a local image (installed if not available in the
shell) and export to the collector
- `smokey_echo_job`: Install echoserver and run a job that sends a POST
request expecting a 405 response
- `smokey_copy_output`: After a short wait, copy output from the newly
created file saved with telemetry from collector
- `smokey_verify_output`: Make assertions via the new `verify.bats` bats
test (similar to previous tests on other distros and in go
auto-instrumentation) that the output contains the expected span and
attributes
- `smoke`: Do all of the things above
- `unsmoke`: Tear it all down when done

Also updated PR, main, and release workflows to run the new smoke test.

## How to verify that this has the expected result

- Run `make smoke` and get a bunch of passing tests - also check out the
(git ignored) json file that contains the remaining span that's being
tested. `make unsmoke` to spin it down.

---------

Co-authored-by: Mike Goldsmth <[email protected]>
Co-authored-by: Jamie Danielson <[email protected]>
Co-authored-by: JamieDanielson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: maintenance The necessary chores to keep the dust off.
Projects
None yet
Milestone
Pre beta
Development

Successfully merging a pull request may close this issue.

maint: adding proper smoke test(s) honeycombio/honeycomb-network-agent
3 participants
@robbkidd @MikeGoldsmith @vreynolds