Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(observability-pipeline): use pvc for cacheing latest config #421

Merged
merged 3 commits into from
Feb 4, 2025
Merged

feat(observability-pipeline): use pvc for cacheing latest config #421

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ec3a30
feat(observability-pipeline): use pvc for cacheing latest config
VinozzZ Jan 24, 2025
88cde5f
actually mount the volumn
VinozzZ Feb 3, 2025
98867a3
only add args if telemetry is enabled or pvc is defined
VinozzZ Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/observability-pipeline/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: observability-pipeline
description: Chart to deploy both OpenTelemetry Collector and Honeycomb Refinery
type: application
version: 0.0.10-alpha
version: 0.0.11-alpha
appVersion: 0.0.1-alpha
keywords:
- refinery
Expand Down
19 changes: 16 additions & 3 deletions charts/observability-pipeline/templates/control-plane-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,15 @@ spec:
- name: {{ .Chart.Name }}
image: "{{ .Values.controlPlane.image.repository }}:{{ .Values.controlPlane.image.tag }}"
imagePullPolicy: {{ .Values.controlPlane.image.pullPolicy }}
{{- if .Values.controlPlane.telemetry.enabled }}
args:
{{- if .Values.controlPlane.telemetry.enabled }}
TylerHelmuth marked this conversation as resolved.
Show resolved Hide resolved
- -otel-config
- /etc/straws-control-plane/otel-config.yaml
{{- end }}
{{- if .Values.controlPlane.persistentVolumeClaimName }}
- -config-cache-path
- /app/straws-control-plane/cache
{{- end }}
env:
- name: HONEYCOMB_API
value: {{ .Values.controlPlane.endpoint }}
Expand All @@ -46,12 +50,17 @@ spec:
resources:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- if or .Values.controlPlane.volumeMounts .Values.controlPlane.telemetry.enabled }}
{{- if or .Values.controlPlane.volumeMounts .Values.controlPlane.telemetry.enabled .Values.controlPlane.persistentVolumeClaimName }}
volumeMounts:
{{- if .Values.controlPlane.telemetry.enabled }}
- name: otel-config
mountPath: /etc/straws-control-plane
{{- end }}
{{- if .Values.controlPlane.persistentVolumeClaimName }}
- name: latest-config-cache
mountPath: /app/straws-control-plane/cache
readonly: false
{{- end }}
{{- with .Values.controlPlane.volumeMounts }}
{{- toYaml . | nindent 12 }}
{{- end }}
Expand All @@ -63,7 +72,7 @@ spec:
- name: opamp
containerPort: 4320
protocol: TCP
{{- if or .Values.controlPlane.volumeMounts .Values.controlPlane.telemetry.enabled }}
{{- if or .Values.controlPlane.volumeMounts .Values.controlPlane.telemetry.enabled .Values.controlPlane.persistentVolumeClaimName }}
volumes:
{{- if .Values.controlPlane.telemetry.enabled }}
- name: otel-config
Expand All @@ -73,6 +82,10 @@ spec:
- key: otel-config
path: otel-config.yaml
{{- end }}
{{- if .Values.controlPlane.persistentVolumeClaimName }}
- name: latest-config-cache
persistentVolumeClaimName: {{ .Values.controlPlane.persistentVolumeClaimName }}
{{- end }}
{{- with .Values.controlPlane.volumes }}
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down
1 change: 1 addition & 0 deletions charts/observability-pipeline/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ controlPlane:
pipelineInstallationID: ""
team: ""
publicMgmtKey: ""
persistentVolumeClaimName: ""
environment:
- name: HONEYCOMB_MGMT_API_SECRET
valueFrom:
Expand Down