Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveJob rescued exceptions should not be reported #537

Closed
stympy opened this issue Apr 11, 2024 · 2 comments · Fixed by #551 or #552
Closed

ActiveJob rescued exceptions should not be reported #537

stympy opened this issue Apr 11, 2024 · 2 comments · Fixed by #551 or #552
Assignees
@stympy
Labels
bug help wanted

Comments

@stympy
Copy link
Member

stympy commented Apr 11, 2024 •
edited by joshuap
Loading

As reported here, we are reporting exceptions that are being rescued via rescue_from, and we shouldn't be.

Front logo Front conversations
@stympy stympy self-assigned this May 23, 2024
stympy added a commit that referenced this issue May 23, 2024
@stympy
Don't duplicate the error handling done by GoodJob
cd03b3c 
Fixes #537
@stympy stympy mentioned this issue May 23, 2024
Merged
@stympy
Copy link
Member Author

stympy commented May 23, 2024

@segiddins I think #551 will fix the problem you encountered with too many reports being sent after you upgraded the gem. If you try the branch, please let me know how it works out for you!

stympy added a commit that referenced this issue May 24, 2024
@stympy
fix: don't duplicate the error handling done by GoodJob (#551)
a0bab0d 
Fixes #537
@github-actions github-actions bot mentioned this issue May 24, 2024
Merged
@stympy
Copy link
Member Author

stympy commented May 24, 2024

This fix is available in gem version 5.10.2.

@simi simi mentioned this issue Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stympy stympy

Labels
bug help wanted
Projects
None yet
Milestone
No milestone
2 participants
@stympy @joshuap