Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for link requests #8

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Wait for link requests #8

merged 1 commit into from
Aug 12, 2023

Conversation

dnicolson
Copy link
Contributor

♻️ Current situation

Opening a plugin's settings in Homebridge UI can result in jank due to the large CSS file loading.

💡 Proposed solution

Wait for the CSS file to load.

Before:

Before.mov

After:

After.mov

@bwp91
Copy link
Contributor

bwp91 commented Aug 12, 2023

Fab, thanks!

@bwp91 bwp91 merged commit 83974d6 into homebridge:master Aug 12, 2023
@donavanbecker
Copy link
Contributor

@dnicolson, this is [email protected], can you verify it is working for you?

@dnicolson
Copy link
Contributor Author

@donavanbecker the plugin-ui-utils code comes from this path in my instance:
/opt/homebridge/lib/node_modules/homebridge-config-ui-x/public/assets/plugin-ui-utils/ui.js

This code doesn't appear to be run:
/var/lib/homebridge/node_modules/@switchbot/homebridge-switchbot/node_modules/@homebridge/plugin-ui-utils/dist/ui.js

@bwp91
Copy link
Contributor

bwp91 commented Aug 18, 2023

this PR is still needed right? was this a dependency for homebridge/homebridge-config-ui-x#1522?

@donavanbecker
Copy link
Contributor

donavanbecker commented Aug 19, 2023

@dnicolson New test version of Homebridge UI is out.

Thanks!

@dnicolson
Copy link
Contributor Author

@bwp91 these are two distinct issues but the goal is the same.

Can someone also create a new release and bump https://github.com/homebridge/homebridge-config-ui-x/blob/abd12e3/ui/package.json#L23?

@donavanbecker
Copy link
Contributor

@dnicolson Will do, any more PRs need on Config UI? If not I will create a release and release it.

@dnicolson
Copy link
Contributor Author

That should be it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants