Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooltip position #1676

Merged
merged 2 commits into from
Nov 9, 2023
Merged

tooltip position #1676

merged 2 commits into from
Nov 9, 2023

Conversation

mkz212
Copy link
Contributor

@mkz212 mkz212 commented Nov 9, 2023

This should fix this

Zrzut ekranu 2023-11-9 o 19 46 03

@bwp91
Copy link
Contributor

bwp91 commented Nov 9, 2023

It's not the position of the tooltip, it's when on a mobile, you click the icon to update a plugin, and the tooltip still appears in front of the modal that opens, like in my image in the other PR

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 9, 2023

Yes, I know! I'm working on it now. This PR is other fix.

@bwp91 bwp91 changed the base branch from latest to beta-4.52.2 November 9, 2023 19:46
@bwp91
Copy link
Contributor

bwp91 commented Nov 9, 2023

I rebased against the beta branch and there is a conflict that needs fixing

@bwp91 bwp91 merged commit 1f4b742 into homebridge:beta-4.52.2 Nov 9, 2023
@mkz212 mkz212 deleted the patch-9 branch November 10, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants