Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small layout fix #1655

Merged
merged 1 commit into from
Nov 8, 2023
Merged

small layout fix #1655

merged 1 commit into from
Nov 8, 2023

Conversation

mkz212
Copy link
Contributor

@mkz212 mkz212 commented Nov 7, 2023

No description provided.

@donavanbecker
Copy link
Contributor

We will have to wait a little to merge this, but thanks!

@donavanbecker donavanbecker enabled auto-merge (squash) November 8, 2023 02:18
@donavanbecker donavanbecker merged commit 057a83d into homebridge:beta-4.52.2 Nov 8, 2023
@mkz212
Copy link
Contributor Author

mkz212 commented Nov 8, 2023

  • Something changed and now second menu on mobile is full with?

  • Logs is not translated.

  • UI Settings is Settings now?

IMG_4335

@donavanbecker
Copy link
Contributor

  • Something changed and now second menu on mobile is full with?

Not sure on this one, I haven't changed anything.

  • Logs is not translated.

  • UI Settings is Settings now?

Both of these need to be updated in the language files. UI was showing twice for English. So it was show UI UI Settings.

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 8, 2023

Can I take care of it, if you want?

@donavanbecker
Copy link
Contributor

Yes

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 8, 2023

Simple option is change in en from "UI Settings" to "Settings" and add UI + translated settings.The question is whether the UI is supposed to be as untranslatable (as a plugin name?) Is it supposed to translate into other languages? (to be e.g.: Interface Settings etc.?).

@bwp91
Copy link
Contributor

bwp91 commented Nov 8, 2023

The translation should be “UI Settings”
There should be nothing else hardcoded to add to the translation

@bwp91
Copy link
Contributor

bwp91 commented Nov 8, 2023

i don’t know what makes more sense in polish. but a lot of the other translations already have UI in them

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 8, 2023

ok. why now i cannot simply update?

Zrzut ekranu 2023-11-8 o 06 51 46

@donavanbecker
Copy link
Contributor

this is fixed in beta.43 but you will have to manually update.

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 8, 2023

About this menu... Problem is width:

Zrzut ekranu 2023-11-8 o 07 08 20

There should be something like:

max-width: 300px;

or

max-width: 70%;

@mkz212 mkz212 deleted the patch-8 branch November 9, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants