Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to Homebridge in footer #1639

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Add link to Homebridge in footer #1639

merged 6 commits into from
Nov 7, 2023

Conversation

mkz212
Copy link
Contributor

@mkz212 mkz212 commented Nov 6, 2023 •
edited
Loading

  • Word "Homebridge" will be a link to: https://github.com/homebridge .
  • There is a link to Config Ui and a link to oznu, so Homebridge should be too.
  • I changed the order slightly: "Originaly created by oznu" should refer to Config Ui, because the author of Homebridge is Nick Farina (maybe it's also worth adding?).

So it should be:
© 2023 Homebridge. homebridge-config-ui-x v4.52.1 - originally created by oznu.

@bwp91 bwp91 changed the base branch from latest to beta-4.52.2 November 7, 2023 08:23
bwp91
bwp91 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@bwp91 bwp91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bwp91 bwp91 merged commit 306f4fc into homebridge:beta-4.52.2 Nov 7, 2023
@mkz212 mkz212 deleted the footer-link-to-homebridge branch November 9, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwp91 bwp91 bwp91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkz212 @bwp91