Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with GitHub Actions #1542

Merged
merged 4 commits into from
Sep 19, 2023
+7 −17
Merged

Fix issues with GitHub Actions #1542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c4ec60
Resolve issues with GitHub actions
NorthernMan54 Sep 19, 2023
38451f8
Update build.yml
NorthernMan54 Sep 19, 2023
f7462b1
Update test.yml and temporarily remove Node 20
NorthernMan54 Sep 19, 2023
d4079d7
Update win32.ts
NorthernMan54 Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ jobs:

uses: homebridge/.github/.github/workflows/nodejs-build-and-test.yml@main
with:
enable_coverage: true
enable_coverage: false
## Code Coverage can only be used in a single run, not in a parallel run - Error: Bad response: 422 {"message":"Can't add a job to a build that is already closed. Build 6224987022 is closed. See docs.coveralls.io/parallel-builds","error":true}
## Coveralls only expects to create a report once per build
runs_on: ${{ matrix.os }}
install_cmd: npm ci && cd ui && npm ci
secrets:
Expand All @@ -27,20 +29,14 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
node-version: [18.x, 20.x]
node-version: [18.x]
include:
- os: macos-latest
node-version: 18.x
- os: macos-latest
node-version: 20.x
- os: windows-2019
node-version: 18.x
- os: windows-2019
node-version: 20.x
- os: windows-latest
node-version: 18.x
- os: windows-latest
node-version: 20.x

runs-on: ${{ matrix.os }}

Expand Down
10 changes: 2 additions & 8 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,25 +7,19 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [18.x, 20.x]
node-version: [18.x]
include:
- os: macos-latest
node-version: 18.x
- os: macos-latest
node-version: 20.x
- os: windows-2019
node-version: 18.x
- os: windows-2019
node-version: 20.x
- os: windows-latest
node-version: 18.x
- os: windows-latest
node-version: 20.x

runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
Expand Down
2 changes: 1 addition & 1 deletion src/bin/platforms/win32.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export class Win32Installer extends BasePlatform {
* This is used to create the Windows Services
*/
private async downloadNssm(): Promise<string> {
const downloadUrl = `https://github.com/homebridge/nssm/releases/download/2.24-101-g897c7ad/nssm_${os.arch()}.exe`;
const downloadUrl = `https://github.com/oznu/nssm/releases/download/2.24-101-g897c7ad/nssm_${os.arch()}.exe`;
const nssmPath = path.resolve(this.hbService.storagePath, 'nssm.exe');

if (await fs.pathExists(nssmPath)) {
Expand Down