fix hb-servce update-node updater

CHANGELOG.md

@@ -4,10 +4,15 @@ All notable changes to this project will be documented in this file. This projec
 
 ## NEXT
 
+### Bug Fixes
+
+* **System:** Added a fix to the [`hb-service update-node`](https://github.com/oznu/homebridge-config-ui-x/wiki/Homebridge-Service-Command#update-nodejs) command to prevent it breaking npm when uprading from Node 14 to 16
+
 ### Other Changes 
 
 * **i18n:** Improvements to Ukrainian language translations ([#1197](https://github.com/oznu/homebridge-config-ui-x/pull/1197))
 * **i18n:** Improvements to Thai language translations ([#1200](https://github.com/oznu/homebridge-config-ui-x/pull/1200))
+* **i18n:** Improvements to Traditional Chinese language translations ([#1240](https://github.com/oznu/homebridge-config-ui-x/pull/1240))
 * **Plugins:** The following features have been added to assist plugin developers building [custom plugin user interfaces](https://github.com/homebridge/plugin-ui-utils):
   * The "loading" spinner is now correctly shown on top of schema generated forms ([#1198](https://github.com/oznu/homebridge-config-ui-x/pull/1198))
 

src/bin/hb-service.ts

@@ -1098,6 +1098,24 @@ export class HomebridgeServiceHelper {
     }
   }
 
+  /**
+   * Remove npm package
+   */
+  public async removeNpmPackage(npmInstallPath: string) {
+    if (!await fs.pathExists(npmInstallPath)) {
+      return;
+    }
+
+    const spinner = ora(`Cleaning up npm at ${npmInstallPath}...`).start();
+
+    try {
+      await fs.remove(npmInstallPath);
+      spinner.succeed(`Cleaned up npm at at ${npmInstallPath}`);
+    } catch (e) {
+      spinner.fail(e.message);
+    }
+  }
+
   /**
    * Check the current status of the Homebridge UI by calling it's API
    */

src/bin/platforms/darwin.ts

@@ -240,6 +240,9 @@ export class DarwinInstaller {
         unlink: true,
       };
 
+      // remove npm package as this can cause issues when overwritten by the node tarball
+      await this.hbService.removeNpmPackage(path.resolve(targetPath, 'lib', 'node_modules', 'npm'));
+
       // extract
       await this.hbService.extractNodejs(job.target, extractConfig);
 

src/bin/platforms/linux.ts

@@ -287,6 +287,9 @@ export class LinuxInstaller {
         unlink: true,
       };
 
+      // remove npm package as this can cause issues when overwritten by the node tarball
+      await this.hbService.removeNpmPackage(path.resolve(targetPath, 'lib', 'node_modules', 'npm'));
+
       // extract
       await this.hbService.extractNodejs(job.target, extractConfig);