Skip to content

Commit

Permalink
improvements to GH actions and build processes
Browse files Browse the repository at this point in the history
Co-Authored-By: Northern Man <[email protected]>
  • Loading branch information
bwp91 and NorthernMan54 committed Jan 24, 2025
1 parent 3760d2b commit 5f20fb8
Show file tree
Hide file tree
Showing 5 changed files with 40 additions and 82 deletions.
22 changes: 22 additions & 0 deletions .github/workflows/beta-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,30 @@ on:
branches: [beta-*.*.*, beta]
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}
cancel-in-progress: true

jobs:
build_and_test:
name: Build and run npm test
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, ubuntu-24.04, ubuntu-22.04, ubuntu-20.04, macos-latest, macos-15, macos-14, macos-13, windows-latest, windows-2022, windows-2019]

uses: homebridge/.github/.github/workflows/nodejs-build-and-test.yml@latest
with:
enable_coverage: false
# # Code Coverage can only be used in a single run, not in a parallel run - Error: Bad response: 422 {"message":"Can't add a job to a build that is already closed. Build 6224987022 is closed. See docs.coveralls.io/parallel-builds","error":true}
# # Coveralls only expects to create a report once per build
runs_on: ${{ matrix.os }}
install_cmd: npm ci && cd ui && npm ci
secrets:
token: ${{ secrets.GITHUB_TOKEN }}

publish:
needs: [build_and_test]
if: ${{ github.repository == 'homebridge/homebridge-config-ui-x' }}
uses: homebridge/.github/.github/workflows/npm-publish.yml@latest
with:
Expand Down
69 changes: 0 additions & 69 deletions .github/workflows/test.yml

This file was deleted.

25 changes: 13 additions & 12 deletions .github/workflows/build.yml → .github/workflows/validate.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Node Build
name: Validate Package

on:
push:
Expand All @@ -8,12 +8,17 @@ on:
types: [review_requested, ready_for_review]
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}
cancel-in-progress: true

jobs:
build_and_test:
name: Build and run npm test
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-2019]
os: [ubuntu-latest, ubuntu-24.04, ubuntu-22.04, ubuntu-20.04, macos-latest, macos-15, macos-14, macos-13, windows-latest, windows-2022, windows-2019]

uses: homebridge/.github/.github/workflows/nodejs-build-and-test.yml@latest
with:
Expand All @@ -25,20 +30,16 @@ jobs:
secrets:
token: ${{ secrets.GITHUB_TOKEN }}

test_hb_service:
# Validate that the UI can be installed and ran across all platforms
validate_service_starts:
needs: build_and_test
name: Validate
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest]
node-version: [18.x]
include:
- os: macos-latest
node-version: 18.x
- os: windows-2019
node-version: 18.x
- os: windows-latest
node-version: 18.x
os:
[ubuntu-latest, ubuntu-24.04, ubuntu-22.04, ubuntu-20.04, macos-latest, macos-15, macos-14, macos-13, windows-latest, windows-2022, windows-2019]
node-version: [18.x, 20.x, 22.x]

runs-on: ${{ matrix.os }}

Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ All notable changes to `homebridge-config-ui-x` will be documented in this file.
- fix typos in hb/ui settings schemas (#2317) (@dnicolson)
- fix margins in update plugin modal

### Other Changes

- improvements to GH actions and build processes (@NorthernMan54)

### Homebridge Dependencies

- `@homebridge/hap-client` @ `v2.0.5`
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
"name": "oznu"
},
{
"email": "buyminivan-northern@yahoo.ca",
"email": "northern[email protected]",
"name": "northernman"
},
{
Expand Down

0 comments on commit 5f20fb8

Please sign in to comment.