Skip to content

Commit

Permalink
Fixes to release workflow (#1492)
Browse files Browse the repository at this point in the history
  • Loading branch information
NorthernMan54 authored May 12, 2023
1 parent 2373453 commit 319749c
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/attach-artifact.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ jobs:

# Sanity check to ensure that release tags don't start with a 'v' version prefix but adhere to the X.Y.Z format
- name: Check for Tag name Format
if: startWith(${{github.event.release.tag_name}}, 'v')
# https://github.com/orgs/community/discussions/25017
if: startsWith(github.event.release.tag_name, 'v')
run: |
echo "Tag name must not start with 'v' Prefix"
echo "Release Tag name must not start with 'v', this was supplied ${{github.event.release.tag_name}}"
exit 1
- name: Install package
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ jobs:
uses: homebridge/.github/.github/workflows/nodejs-build-and-test.yml@main
with:
enable_coverage: true
runs_on: ${{ matrix.os }}
install_cmd: npm ci && cd ui && npm ci
secrets:
token: ${{ secrets.GITHUB_TOKEN }}

Expand Down Expand Up @@ -89,3 +91,5 @@ jobs:
lint:
needs: build_and_test
uses: homebridge/.github/.github/workflows/eslint.yml@main
with:
install_cmd: npm ci && cd ui && npm ci
1 change: 1 addition & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
uses: homebridge/.github/.github/workflows/nodejs-build-and-test.yml@main
with:
enable_coverage: true
install_cmd: npm ci && cd ui && npm ci
secrets:
token: ${{ secrets.GITHUB_TOKEN }}

Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 4.50.4 (2023-05-12)

### Notable Changes

* **System:** Updates to workflow release process

## 4.50.3 (2023-05-12)

### Notable Changes
Expand Down

0 comments on commit 319749c

Please sign in to comment.