Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Remove deprecated BridgedCore.ts & Core.ts #1001

Closed
wants to merge 6 commits into from

Conversation

bdsoha
Copy link

@bdsoha bdsoha commented Apr 3, 2023

As noted in the code itself, this has been deprecated over 2.5 years ago:

console.warn("DEPRECATION NOTICE: The use of Core and BridgeCore are deprecated and are scheduled to be remove in October 2020. " +
   "For more information and some guidance on how to migrate, have a look at https://github.com/homebridge/HAP-NodeJS/wiki/Deprecation-of-Core-and-BridgeCore")

@Supereg Supereg changed the base branch from master to beta-1.0.0 April 20, 2023 13:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4754673728

  • 19 of 21 (90.48%) changed or added relevant lines in 6 files are covered.
  • 140 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 64.946%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/datastream/DataStreamParser.ts 0 1 0.0%
src/lib/util/eventedhttp.ts 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
src/lib/Service.ts 46 71.27%
src/lib/Characteristic.ts 94 81.68%
Totals Coverage Status
Change from base Build 4754650974: 0.2%
Covered Lines: 7259
Relevant Lines: 10409

💛 - Coveralls

@Supereg Supereg changed the base branch from beta-1.0.0 to master April 20, 2023 13:11
@Supereg Supereg changed the base branch from master to beta-1.0.0 April 20, 2023 13:11
Supereg added a commit that referenced this pull request Apr 20, 2023
@Supereg Supereg closed this Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants