-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do optimistic state update for Z-Wave multilevel switch entities #90490
Conversation
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Looks good, I think. @AlCalzone is it correct that Multilevel Switch CC is the only command class where we need the optimistic update? |
Turning a multilevel switch on (with no known target value) is the only one that comes to mind. All others should automatically get optimistic value updates from the driver. |
So does this issue only occur when we send 255? Right now this PR is set to do optimistic updates for all values sent |
If it's simpler, should only be necessary to do for 255, the driver provides optimistic state update for the others. That's what I did for a POC I tried, and it worked well. |
we can only cover lights and fans because they are toggle entities. For covers, numbers, and selects, we don't know the previous state. We could store it if needed but I think lights and fans were primarily where the problem was anyway |
Looks good. |
…at the previous state is known by the integration due to the service being called
Proposed change
In this PR we do optimistic state updates for all Z-Wave Multilevel Switch CC based entities except for the cover entity - because we don't track
is_closing
andis_opening
for Multilevel Switch covers, I don't think there is any optimistic state to set (if #90492 gets merged then I can add optimistic state update support for covers in this PR).Before I add tests I wanted to put up the implementation for review to make sure I understood the problem correctly.
Resolves #90399
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: