Bump influxdb-client dependency to 1.24.0

[mdegat01]

Proposed change

Update influxdb-client dependency from 1.14.0 to 1.24.0 (full changelog). Used for communication with InfluxDB 2.0 deployments.

Note that there were breaking changes in 1.18.0. I have reviewed them and they were to APIs we don't use. I also tested locally and confirmed things work fine.

One nice addition is influxdata/influxdb-client-python#264 as it means users can now use the more user-friendly and easier to find name instead of tracking down the ID. We don't have to do anything else to make use of this, ID still works and now name does too. Other then that mostly bugfixes from our perspective.

Notes on included code changes:

• Change to __init__.py is due to No request timeout causing points not being written to influxdb influxdata/influxdb-client-python#221 . The code was passing a value for timeout in seconds since that's what the V1 client wanted. It appears the V2 client wants milliseconds but timeout simply didn't work before. Now that it does we must correct the value.
• Changes to tests are due to fix: construct InfluxDBError without http response influxdata/influxdb-client-python#375 . When error handling was reworked in 1.22.0 a small issue was introduced where ApiException could no longer be created without an HTTPResponse. This is a scenario that only comes up in tests but we were relying on it. Modified the tests to pass a MagicMock to stop the NoneType exception.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[mdegat01]

Ah shoot forgot to update the manifest, so I guess my test was invalid. Give me a moment, sorry about that.

[mdegat01]

Ok that's rather amusing. Looks like a bit of a surprise breaking change for us. We were passing timeout as 5 because the V1 InfluxDB client accepted a timeout in seconds. The V2 client had the same input so I assumed it was also in seconds, it didn't specify a unit. Apparently it just didn't work at all influxdata/influxdb-client-python#221 . Now it's fixed and they clarified the unit is in milliseconds.

So I will also have to make a small change as part of this PR to account for that.

[mdegat01]

So have been digging into this, appears something changed which broke the tests between 1.21.0 and 1.22.0. Went up release by release and that's where the failures start. Will need to update them as well I suppose, hopefully its small. Didn't expect this to be so involved but I guess that's how it goes with dependency upgrades sometimes.

[mdegat01]

Ok figured it out. It appears release 1.22.0 brought some significant improvements to error handling. I remember struggling with that initially and figuring out what exceptions to catch in each situation mostly by trial and error. Now there is one exception class the author has normalized everything to which is great, I'll do some refactoring in a future PR.

The one downside is the new Exception class didn't account for scenarios that really only come up in testing. Namely someone tries to create an instance of ApiException but doesn't have an actual HTTPResponse which is what the tests were doing to create mock exceptions. Solving this required a small tweak to the tests, passing a MagicMock as the http response so we don't get "accessing attribute of NoneType" errors.

The issue is actually already fixed in dev tip by influxdata/influxdb-client-python#375 but I'm not sure when the next release is. Figured it was better to get up to date since this only warranted a minor change and now error handling needs a refactor anyway.

[frenck]

Thanks, @mdegat01 👍

Happy New Year 🍾