Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump xiaomi_miio dependency #60650

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Bump xiaomi_miio dependency #60650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eb7892
Bump xiaomi_miio dependency
rytilahti Nov 30, 2021
3583493
Fix mocking
rytilahti Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions homeassistant/components/xiaomi_miio/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
FanP10,
FanP11,
FanZA5,
RoborockVacuum,
Timer,
Vacuum,
VacuumStatus,
)
from miio.gateway.gateway import GatewayException
Expand Down Expand Up @@ -212,7 +212,7 @@ class VacuumCoordinatorDataAttributes:
fan_speeds_reverse: str = "fan_speeds_reverse"


def _async_update_data_vacuum(hass, device: Vacuum):
def _async_update_data_vacuum(hass, device: RoborockVacuum):
def update() -> VacuumCoordinatorData:
timer = []

Expand Down Expand Up @@ -313,7 +313,7 @@ async def async_create_miio_device_and_coordinator(
or model.startswith(ROBOROCK_GENERIC)
or model.startswith(ROCKROBO_GENERIC)
):
device = Vacuum(host, token)
device = RoborockVacuum(host, token)
update_method = _async_update_data_vacuum
coordinator_class = DataUpdateCoordinator[VacuumCoordinatorData]
# Pedestal fans
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/xiaomi_miio/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "Xiaomi Miio",
"config_flow": true,
"documentation": "https://www.home-assistant.io/integrations/xiaomi_miio",
"requirements": ["construct==2.10.56", "micloud==0.4", "python-miio==0.5.8"],
"requirements": ["construct==2.10.56", "micloud==0.4", "python-miio==0.5.9"],
"codeowners": ["@rytilahti", "@syssi", "@starkillerOG", "@bieniu"],
"zeroconf": ["_miio._udp.local."],
"iot_class": "local_polling"
Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1907,7 +1907,7 @@ python-kasa==0.4.0
# python-lirc==1.2.3

# homeassistant.components.xiaomi_miio
python-miio==0.5.8
python-miio==0.5.9

# homeassistant.components.mpd
python-mpd2==3.0.4
Expand Down
2 changes: 1 addition & 1 deletion requirements_test_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,7 +1145,7 @@ python-juicenet==1.0.2
python-kasa==0.4.0

# homeassistant.components.xiaomi_miio
python-miio==0.5.8
python-miio==0.5.9

# homeassistant.components.nest
python-nest==4.1.0
Expand Down
12 changes: 9 additions & 3 deletions tests/components/xiaomi_miio/test_vacuum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,9 @@ def mirobo_is_got_error_fixture():

mock_vacuum.timer.return_value = [mock_timer_1, mock_timer_2]

with patch("homeassistant.components.xiaomi_miio.Vacuum") as mock_vacuum_cls:
with patch(
"homeassistant.components.xiaomi_miio.RoborockVacuum"
) as mock_vacuum_cls:
mock_vacuum_cls.return_value = mock_vacuum
yield mock_vacuum

Expand Down Expand Up @@ -149,7 +151,9 @@ def mirobo_old_speeds_fixture(request):
2020, 4, 1, 13, 21, 10, tzinfo=dt_util.UTC
)

with patch("homeassistant.components.xiaomi_miio.Vacuum") as mock_vacuum_cls:
with patch(
"homeassistant.components.xiaomi_miio.RoborockVacuum"
) as mock_vacuum_cls:
mock_vacuum_cls.return_value = mock_vacuum
yield mock_vacuum

Expand Down Expand Up @@ -209,7 +213,9 @@ def mirobo_is_on_fixture():

mock_vacuum.timer.return_value = [mock_timer_1, mock_timer_2]

with patch("homeassistant.components.xiaomi_miio.Vacuum") as mock_vacuum_cls:
with patch(
"homeassistant.components.xiaomi_miio.RoborockVacuum"
) as mock_vacuum_cls:
mock_vacuum_cls.return_value = mock_vacuum
yield mock_vacuum

Expand Down