Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile app to use device tracker config entry #24238

Merged
merged 4 commits into from
Jun 1, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Jun 1, 2019

Breaking Change:

Entity IDs will be based on the name of the device. Since there is a unique ID, it is now possible to change this, and the name, via the entity registry.

Description:

Make the mobile app use the device tracker config entry support.

Checklist:

  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost
Copy link

ghost commented Jun 1, 2019

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration (mobile_app) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob added this to the 0.94.0 milestone Jun 1, 2019
@robbiet480 robbiet480 merged commit b4374c8 into dev Jun 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the mobile-app-device-tracker branch June 1, 2019 06:01
balloob added a commit that referenced this pull request Jun 1, 2019
* Mobile app to use device tracker config entry

* Lint

* Re-use device_info

* Lint
@balloob balloob mentioned this pull request Jun 4, 2019
@joshtbernstein
Copy link

Before I create an issue, this is only for the device_tracker entity from the mobile app, not any of the other entities created by the mobile app, correct?

@balloob
Copy link
Member Author

balloob commented Jun 6, 2019

Correct

alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
* Mobile app to use device tracker config entry

* Lint

* Re-use device_info

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants