Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SSDP error handling #24204

Merged
merged 1 commit into from
May 30, 2019
Merged

Improve SSDP error handling #24204

merged 1 commit into from
May 30, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented May 30, 2019

Description:

Improve SSDP error handling.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.94.0 milestone May 30, 2019
@balloob balloob changed the title Improve error handling Improve SSDP error handling May 30, 2019
@balloob balloob merged commit 6f299e7 into dev May 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-ssdp-none-error branch May 30, 2019 23:23
balloob added a commit that referenced this pull request May 31, 2019
@balloob
Improve error handling (#24204)
6371eca
@balloob balloob mentioned this pull request Jun 4, 2019
Merged
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
@balloob @alandtse
Improve error handling (home-assistant#24204)
0269dd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cherry-picked cla-signed has-tests integration: ssdp small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.94.0
Development

Successfully merging this pull request may close these issues.
2 participants
@balloob @homeassistant