Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix patching right import #23816

Merged
merged 1 commit into from
May 11, 2019
Merged

Fix patching right import #23816

merged 1 commit into from
May 11, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented May 11, 2019

Description:

When we moved imports for Hue around, this patch wasn't updated. It means that we were doing a nupnp query each test run, oops. This fixes it.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant homeassistant added has-tests small-pr PRs with less than 30 lines. cla-signed labels May 11, 2019
@balloob balloob mentioned this pull request May 11, 2019
Merged
8 tasks
@Danielhiversen Danielhiversen merged commit 3ec4070 into dev May 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-hue-test branch May 11, 2019 17:29
@balloob balloob mentioned this pull request Jun 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed has-tests small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balloob @MartinHjelmare @Danielhiversen @homeassistant